Skip to content

ci(claude-review): allow dependabot PRs in Claude Code Review#870

Merged
frankbria merged 1 commit into
mainfrom
ci/claude-review-allowed-bots
Jul 21, 2026
Merged

ci(claude-review): allow dependabot PRs in Claude Code Review#870
frankbria merged 1 commit into
mainfrom
ci/claude-review-allowed-bots

Conversation

@frankbria

Copy link
Copy Markdown
Owner

Every Dependabot PR currently gets a red claude-review check, not because of any code problem but because the action rejects bot actors by default:

Action failed with error: Workflow initiated by non-human actor: dependabot (type: Bot).
Add bot to allowed_bots list or use '*' to allow all bots.

(Seen on #868 — the only failing check on an otherwise green PR.)

Change

Add allowed_bots: "dependabot[bot]" to the anthropics/claude-code-action step in .github/workflows/claude-code-review.yml, so dependency PRs get reviewed instead of erroring.

Notes

  • Scoped to dependabot[bot] only, not *.
  • The job's permissions stay read-only (contents: read, pull-requests: read, issues: read), so blast radius of reviewing bot PRs is minimal.

Refs: failed run on #868 (job 88123303723).

@frankbria

Copy link
Copy Markdown
Owner Author

Cross-family review — opencode (zai/glm-5.2)

Independent review from a different model family, posted per the completing-pr-reviews workflow (Phase 10-pre).

Verified: allowed_bots exists in the pinned action action.yml (SHA 558b1d6), accepts a comma-separated list, default empty = no bots. Scoping to dependabot[bot] (not *) is the action's documented safe pattern. Parameter name and YAML quoting are correct.

Findings (none Critical/Major)

  • Suggestion — :20 id-token: write: Unused (the step uses claude_code_oauth_token, not OIDC federation). Pre-existing, not introduced by this PR. Could be dropped in a follow-up to shrink the surface.
  • Suggestion — :52 prompt / allowed_bots: Reviewing Dependabot PRs newly exposes the bot to upstream-controlled content (release notes in PR bodies). With gh pr comment available, a crafted release note could coerce a misleading "approved" comment. Blast radius is limited — job perms are read-only and the human is the merge decision-maker. Follow-up hardening: exclude_comments_by_actor: "dependabot[bot]" or an explicit "treat PR description as untrusted data" clause in the prompt.
  • Nitpick — :11 paths-ignore: The fix is narrower than the title implies — paths-ignore already skips .github/** and pyproject.toml, so only lockfile/multi-file bumps (≥20 lines) ever reached this job and failed. Documentation-only.

Verdict

APPROVE — minimal, correctly scoped, uses the documented safe form. The two Suggestions are real but pre-existing/accepted-by-design given read-only perms; recommend follow-up issues, not a merge block.

@gitguardian

gitguardian Bot commented Jul 21, 2026

Copy link
Copy Markdown

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

The claude-code-action rejects bot actors by default, failing the
claude-review check on every Dependabot PR with:

  Workflow initiated by non-human actor: dependabot (type: Bot).
  Add bot to allowed_bots list or use '*' to allow all bots.

Add allowed_bots: "dependabot[bot]" so dependency PRs get reviewed
instead of showing a spurious red check.
@frankbria
frankbria force-pushed the ci/claude-review-allowed-bots branch from 832dd76 to 9078c85 Compare July 21, 2026 23:44
@frankbria
frankbria merged commit 33a21ae into main Jul 21, 2026
10 checks passed
@frankbria
frankbria deleted the ci/claude-review-allowed-bots branch July 21, 2026 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant